Owner reference should be re-reconciled if it is lost for CA secret object #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kamaji-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This appears to be the case for more resources than just the CA. Other resources that don't set controller ref when the checksum is valid:
|
prometherion
requested changes
Mar 28, 2024
There was a problem hiding this comment.
As pointed out by @hrak, may I ask you to ensure the controller references to all the secrets, please?
|
Of course, I will do |
|
Hello @hrak. I fixed other secret's owner references. |
prometherion
approved these changes
Apr 2, 2024
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you restore Kamaji tcp from backup, such tool as Velero deletes ownerReference on objects.
This may lead to bug if third-party controller take control under restored objects.
In my case I lost ca.crt and ca.key files in CA secret object.
The problem is described in detail here
According to CAPI specification about owner references:
Kamaji always has to restore owner reference for it's objects.