Use optimistic sorting for columns

clauderic · Sep 21, 2024 · 92676b4 · 92676b4
1 parent 0c7bf85
commit 92676b4
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/apps/stories/stories/react/Sortable/MultipleLists/MultipleLists.tsx b/apps/stories/stories/react/Sortable/MultipleLists/MultipleLists.tsx
@@ -63,15 +63,23 @@ export function MultipleLists({
         }
 
         if (source.type === 'column') {
-          setColumns((columns) => move(columns, source, target));
+          // We can rely on optimistic sorting for columns
           return;
         }
 
+        event.preventDefault();
         setItems((items) => move(items, source, target));
       }}
       onDragEnd={(event) => {
         if (event.canceled) {
           setItems(snapshot.current);
+          return;
+        }
+
+        const {source, target} = event.operation;
+
+        if (source?.type === 'column') {
+          setColumns((columns) => move(columns, source, target));
         }
       }}
     >