Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ts support #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add ts support #24

wants to merge 5 commits into from

Conversation

davidsonsns
Copy link

issue: #23

@pke
Copy link

pke commented Jul 17, 2020

Care to merge @clauderic?

pke
pke reviewed Jul 17, 2020
View reviewed changes
Copy link

@pke pke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR. I was looking for TS support right now ;)
I have made some comments to understand the intention better.

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
pke
pke approved these changes Jul 20, 2020
View reviewed changes
Copy link

@pke pke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Looks good to me.
Hope @clauderic has time to review and I can remove my local typings for this nice library.

@yjb94
Copy link

yjb94 commented Nov 23, 2020

any updates?

@pke
Copy link

pke commented Mar 21, 2021

Good question! Care to merge @clauderic?

@SebastianMieszczanczyk
Copy link

@clauderic up

@pke
Copy link

pke commented Sep 15, 2021

Stale repos are one of the problems in OSS. @clauderic could you maybe designate a maintainer for this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pke pke pke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidsonsns @pke @yjb94 @SebastianMieszczanczyk