Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement fromCallback for node-style callbacks #16

Merged
merged 6 commits into from
May 7, 2024

Conversation

andogq
Copy link
Member

@andogq andogq commented May 7, 2024

Implement fromCallback stream creation method. Allows Windpipe integration with methods that take node-style callbacks.

Example

$.fromCallback((cb) => someFunction(paramA, paramB, cb));

Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: d7a7c42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
windpipe Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@andogq andogq requested a review from giraugh May 7, 2024 01:46
@andogq andogq self-assigned this May 7, 2024
@andogq andogq added the enhancement New feature or request label May 7, 2024
@andogq andogq requested a review from mdboon May 7, 2024 02:06
Copy link
Contributor

@giraugh giraugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks incredibly windy to me

.changeset/green-suns-boil.md Outdated Show resolved Hide resolved
src/util.ts Show resolved Hide resolved
src/stream/base.ts Show resolved Hide resolved
@andogq andogq merged commit 5589c04 into main May 7, 2024
1 check passed
@andogq andogq deleted the feat/from-node-callback branch May 7, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants