Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transforms|batch): Allows batch operator to emit partial batches #40

Closed
wants to merge 1 commit into from
Closed

fix(transforms|batch): Allows batch operator to emit partial batches #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/stream/transforms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ export class StreamTransforms<T, E> extends StreamConsumption<T, E> {
* size, or can be over a period of time.
*
* @param options.n - Batch up to `n` items (activates batching by count)
* @param options.yeildRemaining - If the end of the stream is encountered and there are less
* @param options.yieldRemaining - If the end of the stream is encountered and there are less
* than `n` items buffered, yield them anyway
* @param options.timeout - Batch for `timeout` milliseconds (activates batching by timeout)
* @param options.yieldEmpty - If `timeout` is reached and no items have been emitted on the
Expand Down Expand Up @@ -510,12 +510,12 @@ export class StreamTransforms<T, E> extends StreamConsumption<T, E> {
if (result === "timeout" && "timeout" in options) {
if (totalBatchSize > 0) {
// Work out which batches are ready
const ready = Object.values(batches).filter(
(batch) => batch.length >= (options?.n ?? 1),
);
const ready = Object.values(batches).filter((batch) => batch.length > 0);

for (const batch of ready) {
const items = batch.splice(0, options?.n ?? batch.length);
// If `n` in options and `n` <= batch size, use it
const n = Math.min(options?.n ?? batch.length, batch.length);
const items = batch.splice(0, n);
yield ok<T[], E>(items);
totalBatchSize -= items.length;
}
Expand Down
Loading