Mixer reset #608
Mixer reset #608
Conversation
ashleshaAtrey
force-pushed
the
mixerReset
branch
3 times, most recently
from
6ac0537
to
4d0e202
Compare
ashleshaAtrey
force-pushed
the
mixerReset
branch
5 times, most recently
from
2a433a4
to
e462906
Compare
ashleshaAtrey
force-pushed
the
mixerReset
branch
6 times, most recently
from
317b5c5
to
12eab83
Compare
ashleshaAtrey
force-pushed
the
mixerReset
branch
3 times, most recently
from
fd6eede
to
7ca1bda
Compare
|
I updated the docs, but I am not sure auto-completion. How do we enable that ? |
ashleshaAtrey
force-pushed
the
mixerReset
branch
4 times, most recently
from
2e7cb67
to
e3f6243
Compare
ashleshaAtrey
force-pushed
the
mixerReset
branch
3 times, most recently
from
850bb2d
to
65baba4
Compare
| if err = ioutil.WriteFile(filepath.Join(b.Config.Builder.ServerStateDir, "/www/version/", newFormat, "latest"), []byte(b.MixVer), 0644); err != nil { | ||
| return fmt.Errorf("couldn't update latest file: %s", err) | ||
| } | ||
| //update the sig file for the latest |
There was a problem hiding this comment.
This actually needs to be decided, whether we should update the sig file or not
| if err = ioutil.WriteFile(filepath.Join(b.Config.Builder.ServerStateDir, "/www/version/", "latest_version"), []byte(b.MixVer), 0644); err != nil { | ||
| return fmt.Errorf("couldn't update latest_version file: %s", err) | ||
| } | ||
| //update the sig file for the latest_version |
There was a problem hiding this comment.
same for this, need to decide if updating the sig is a good idea or not
There was a problem hiding this comment.
I don't think mixer reset should change these files. They should be updated by mixer build update. Also, when rolling back the version and re-building, I think that mixer should erase manifests at mix versions ahead of the current mix because they will be corrupted.
@reaganlo Thoughts?
mixer/cmd/reset.go
Outdated
| } | ||
| } | ||
|
|
||
| if b.MixVer == "0"{ |
There was a problem hiding this comment.
mixversions are required to be > 0. Allowing a mix to be reset to 0 will lead to failures later.
mixer init
sudo mixer reset
sudo mixer build all
ERROR: Couldn't build update: failed to create update metadata: manifest has version zero, version must be positive
There was a problem hiding this comment.
yes, I will make it invalid to give reset 0 then
There was a problem hiding this comment.
what will be good approach to reset the mix to a state which is after mixer init?
There was a problem hiding this comment.
If the previous version is 0, I would use the current mixversion. If that is invalid (< 1), I would print a warning and default to 10 which is the mixer init mixversion default.
There was a problem hiding this comment.
@jwakre can you test the recent commit. I made the changes.
ashleshaAtrey
force-pushed
the
mixerReset
branch
2 times, most recently
from
847eede
to
7901e1c
Compare
ashleshaAtrey
force-pushed
the
mixerReset
branch
from
7901e1c
to
357cabb
Compare
It reverts the mix to a previous version in case of a build failure or in case the user wants to roll back to a specific version. By default, the command will bring back the mix to the same state it have when it last build a successful mix. This value can be overridden if a `--to` flag is provided with a version number. The command will not be destructive unless a `--clean` flag is provided specified. If so, mixer will delete all files associated with versions that are bigger than the one provided. If not, only the values of the state files will change, but the files will be kept. Signed-off-by: Ashlesha Atrey <[email protected]>
ashleshaAtrey
force-pushed
the
mixerReset
branch
from
357cabb
to
c2ca375
Compare
It reverts the mix to a good state in case of a build failure or in case the user wants to roll back to a previous version.
By default, the command will bring back the mix to the same state it have when it last build a successful mix.
This value can be overridden if a
--toflag is provided with a version number.The command will not be destructive unless a--cleanflag is provided specified. If so, mixer will delete all files associated with versions that are bigger than the one provided. If not, only the values of the state files will change, but the files will be kept.Signed-off-by: Ashlesha Atrey [email protected]