-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apx support #795
Merged
Merged
Add apx support #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for new APX optimization level using the /V5 prefix. Signed-off-by: William Douglas <[email protected]>
Signed-off-by: William Douglas <[email protected]>
Two left over that are logic changes to be addressed in the next commit. Signed-off-by: William Douglas <[email protected]>
Signed-off-by: William Douglas <[email protected]>
Signed-off-by: William Douglas <[email protected]>
bryteise
force-pushed
the
add-apx-support
branch
4 times, most recently
from
January 26, 2024 20:59
b5073d3
to
ef516f4
Compare
fenrus75
reviewed
Jan 26, 2024
swupd/files.go
Outdated
AVX512_2: "/V4", | ||
AVX512_3: "/V4", | ||
AVX512_6: "/V4", | ||
AVX512_7: "/V4", | ||
APX_4: "/V5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this not be V5 but something like VA in case an actual v5 comes along that's something else
fenrus75
approved these changes
Jan 26, 2024
bryteise
force-pushed
the
add-apx-support
branch
3 times, most recently
from
January 30, 2024 18:34
80e221f
to
2aa8ed1
Compare
Signed-off-by: William Douglas <[email protected]>
fenrus75
approved these changes
Jan 30, 2024
fenrus75
approved these changes
Jan 30, 2024
bryteise
force-pushed
the
add-apx-support
branch
2 times, most recently
from
January 30, 2024 19:24
bf125c9
to
32e01c9
Compare
Don't download the linter unless a special CI env setting is set. Also use a different cache to avoid permissions issues with the rootfs in CI. Signed-off-by: William Douglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.