Add dependency on clearpath_sensors

[civerachb-cpr]

It looks like we're missing the dependency on clearpath_sensors, which can result in the generator failing if this package isn't already installed on the system.

Resolves clearpathrobotics/clearpath_simulator#66

Should be cherry-picked into Jazzy.

[roni-kreinin]

Disregard the approval. clearpath_common should not depend on sensors.

[roni-kreinin]

Simulator should be the one depending on sensors if this is referring to clearpathrobotics/clearpath_simulator#66

[civerachb-cpr]

clearpath_sensors is referenced directly several times inside clearpath_generator_common:

• https://github.com/clearpathrobotics/clearpath_common/blob/humble/clearpath_generator_common/clearpath_generator_common/common.py#L300
• https://github.com/clearpathrobotics/clearpath_common/blob/humble/clearpath_generator_common/clearpath_generator_common/param/platform.py#L61
• https://github.com/clearpathrobotics/clearpath_common/blob/humble/clearpath_generator_common/clearpath_generator_common/param/platform.py#L74
• https://github.com/clearpathrobotics/clearpath_common/blob/humble/clearpath_generator_common/clearpath_generator_common/param/platform.py#L175

Why shouldn't this package depend on it if this is where it's being referenced?

[roni-kreinin]

clearpath_sensors contains launch and config file only for physical sensors, not simulated. It should only be installed on physical robots, hence why it is under the clearpath_robot repo. We may need to move some of these common generator components into the robot and gz generators instead.

[civerachb-cpr]

This is sounding like a much bigger set of structural changes to the packages. Should I schedule a meeting to go over how we want to tackle this?

My first thought is to just create a new clearpath_sensors_config package inside clearpath_common and have both clearpath_generator_common and clearpath_sensors refer to those config files. We're obviously using the physical sensor configurations to inform the simulation.

[roni-kreinin]

Yes it would be worth talking over.