Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add client for predis #75

Merged
merged 14 commits into from
Sep 2, 2024
Merged

Conversation

flug
Copy link

@flug flug commented Aug 29, 2024

No description provided.

@flug flug mentioned this pull request Aug 29, 2024
@flug flug force-pushed the add/predis-dependency branch 2 times, most recently from c24dfec to 98009ff Compare August 29, 2024 19:33
src/Client/PRedisClient.php Outdated Show resolved Hide resolved
src/Client/PRedisClient.php Outdated Show resolved Hide resolved
src/Client/Helper/Converter.php Show resolved Hide resolved
src/Client/PRedisClient.php Outdated Show resolved Hide resolved
@clementtalleu
Copy link
Owner

Thank you very much for you PR @flug ! just 2/3 small changes and we're good to go

@flug flug force-pushed the add/predis-dependency branch 2 times, most recently from 2cfd75d to 7286fdf Compare August 30, 2024 22:40
@clementtalleu clementtalleu self-requested a review August 31, 2024 10:15
@flug flug force-pushed the add/predis-dependency branch 2 times, most recently from 6d3881b to 29a0694 Compare September 2, 2024 13:21
Marc Lemay and others added 12 commits September 2, 2024 16:29
limits the results to the offset and number of results given. Note that the offset is zero-indexed.
The default is 0 10, which returns 10 items starting from the first result.
You can use LIMIT 0 0 to count the number of documents in the result set without actually returning them.
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.46473% with 76 lines in your changes missing coverage. Please review.

Project coverage is 70.65%. Comparing base (e548a5c) to head (06ac1d2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Client/PredisClient.php 71.50% 53 Missing ⚠️
src/Client/RedisClient.php 0.00% 22 Missing ⚠️
src/Om/RedisObjectManager.php 93.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main      #75       +/-   ##
=============================================
- Coverage     82.98%   70.65%   -12.34%     
- Complexity      467      540       +73     
=============================================
  Files            40       42        +2     
  Lines          1017     1213      +196     
=============================================
+ Hits            844      857       +13     
- Misses          173      356      +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flug
Copy link
Author

flug commented Sep 2, 2024

@clementtalleu Bon chance !

Bon Chance

@clementtalleu clementtalleu merged commit 18e04e0 into clementtalleu:main Sep 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants