feat(cypress): Restructure and add Account Portal section #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, here’s your docs preview: https://clerk.com/docs/pr/1679 |
…unt-portal-on-cypress-docs-page
alexisintech
reviewed
Nov 7, 2024
victoriaxyz
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Looking good!
Please check the PR I opened in the quickstart to ensure the code in the test file matches the code you wrote for these docs: clerk/clerk-cypress-nextjs#9
I ran the code and there are errors.
Also, please replace all real Account Portal URLs with mock data.
| it('sign in with Account Portal redirects', () => { | ||
| setupClerkTestingToken() | ||
|
|
||
| cy.origin('https://ready-flea-75.accounts.dev', () => { |
There was a problem hiding this comment.
I would replace all real URLs with mock data.
There was a problem hiding this comment.
Can you advise how mock data should look like? 🙏
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
🔎 Previews:
Explanation:
This PR: