feat: Introduce Waitlist component docs #1696
Conversation
|
Hey, here’s your docs preview: https://clerk.com/docs/pr/1696 |
nikospapcom
force-pushed
the
nikospap/user-620-add-docs-about-the-waitlist-sign-up-mode
branch
2 times, most recently
from
dfe4573 to
f12fde7
Compare
| > [!NOTE] | ||
| > The `<Waitlist />` component is only available in Core 2. If you are using Next.js is available after <code>@clerk/nextjs\@6.2.0</code> |
There was a problem hiding this comment.
We don't need to mention the Core 2 part, because the users are in the Core 2 docs. Core 1 users would be in the Core 1 docs, where none of this would exist because these features don't exist in Core 1.
Do you mean to mention that the Waitlist component will only work with Next.js versions 6.2.0 and above?
There was a problem hiding this comment.
We don't need to mention the Core 2 part, because the users are in the Core 2 docs. Core 1 users would be in the Core 1 docs, where none of this would exist because these features don't exist in Core 1.
Do you mean to mention that the Waitlist component will only work with Next.js versions 6.2.0 and above?
@alexisintech sure I'll remove the reference for Core 2
about nextjs package yes it's available from 6.2.0 and above. The reason is because Waitlist is a totally new component and we can't export in the previous nextjs versions
|
We are removing all JavaScript |
nikospapcom
force-pushed
the
nikospap/user-620-add-docs-about-the-waitlist-sign-up-mode
branch
2 times, most recently
from
adf34a7 to
8787324
Compare
docs/manifest.json
Outdated
| { | ||
| "title": "Waitlist Components", | ||
| "items": [ | ||
| [ | ||
| { | ||
| "title": "`<Waitlist />`", | ||
| "wrap": false, | ||
| "href": "/docs/components/waitlist/overview" | ||
| } | ||
| ] | ||
| ] | ||
| }, |
There was a problem hiding this comment.
what do you think about putting this under the "Authentication components" aka /components/authentication ?
There was a problem hiding this comment.
I don't think that it's the correct section because waitlist as a term is before authentication :) open to discuss it if you have time
There was a problem hiding this comment.
will there ever be other sign-up mode components? maybe we can rename the section to "Sign-up mode components"
If not, then I suppose we should change to "Waitlist component". Not plural components, because there's only one component.
nikospapcom
force-pushed
the
nikospap/user-620-add-docs-about-the-waitlist-sign-up-mode
branch
from
4bfd6a9 to
6d18038
Compare
docs/manifest.json
Outdated
| { | ||
| "title": "Waitlist Components", | ||
| "items": [ | ||
| [ | ||
| { | ||
| "title": "`<Waitlist />`", | ||
| "wrap": false, | ||
| "href": "/docs/components/waitlist/overview" | ||
| } | ||
| ] | ||
| ] | ||
| }, |
There was a problem hiding this comment.
will there ever be other sign-up mode components? maybe we can rename the section to "Sign-up mode components"
If not, then I suppose we should change to "Waitlist component". Not plural components, because there's only one component.
nikospapcom
force-pushed
the
nikospap/user-620-add-docs-about-the-waitlist-sign-up-mode
branch
from
e54fca5 to
320a42a
Compare
|
I think its all good! I just wanna get Victoria's review, and then we can approve :) |
|
you can merge whenever :) |
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
Co-authored-by: victoria <[email protected]>
nikospapcom
force-pushed
the
nikospap/user-620-add-docs-about-the-waitlist-sign-up-mode
branch
from
2cc400a to
1d12c85
Compare
nikospapcom
deleted the
nikospap/user-620-add-docs-about-the-waitlist-sign-up-mode
branch
Important
🔎 Previews:
Explanation:
This PR: