-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO MERGE] Sign-in-or-up docs #1772
Merged
brkalow
merged 41 commits into
main
from
alexcarpenter/sdki-747-launch-draft-docs-changes
Jan 16, 2025
Merged
[DO MERGE] Sign-in-or-up docs #1772
brkalow
merged 41 commits into
main
from
alexcarpenter/sdki-747-launch-draft-docs-changes
Jan 16, 2025
+598
−242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey, here’s your docs preview: https://clerk.com/docs/pr/1772 |
alexcarpenter
changed the title
[WIP] Sign-in combined flow docs
[WIP] Sign-in-or-up combined flow docs
Dec 9, 2024
This was referenced Dec 10, 2024
alexcarpenter
changed the title
[WIP] Sign-in-or-up combined flow docs
[WIP] Sign-in-or-up docs
Dec 10, 2024
3 tasks
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
…thub.com:clerk/clerk-docs into alexcarpenter/sdki-747-launch-draft-docs-changes
zchsh
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💯 🤩
- 👀 I skimmed all the pages linked in the PR description
- ⛏️ For those PR description links, I had to adjust some
signup
vssign-up
differences in the URLs, which is pretty nitpicky so def feel free to ignore. I couldn't find any actual broken links in the docs themselves (... do we have a broken link checker?) - ❓ I found a lil typo-ish bug in the Expo sidebar, I think at some point the
useOauth()
item got dropped and replaced with a duplicatesign-in-or-up
link
Hey, here’s your docs preview: https://clerk.com/docs/pr/1772 |
jacekradko
reviewed
Jan 15, 2025
jacekradko
reviewed
Jan 15, 2025
brkalow
reviewed
Jan 16, 2025
Co-authored-by: Jacek Radko <[email protected]>
brkalow
changed the title
[DO NOT MERGE] Sign-in-or-up docs
[DO MERGE] Sign-in-or-up docs
Jan 16, 2025
brkalow
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
🔎 Previews:
<SignIn />
Next.js:
Expo:
TanStack Start:
Remix:
React Router:
Explanation:
Resolves SDKI-747
We are introducing a combined sign-in-or-up flow that will be the default experience using the
<SignIn />
component. Users will be able to still opt-in to a custom<SignUp />
page by adding a custom sign-up route along with setting theirCLERK_SIGN_UP_URL
.This PR:
<SignIn />
componentChecklist