Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clarify email address sign up requirements #1793

Merged
merged 3 commits into from
Dec 11, 2024
Merged

fix: clarify email address sign up requirements #1793

merged 3 commits into from
Dec 11, 2024

Conversation

dstaley
Copy link
Member

@dstaley dstaley commented Dec 10, 2024 •
edited
Loading

Important

🔎 Previews:

Explanation:

  • The docs currently make it sound like an email address is required at all times, when in reality it's only required if email address is the only enabled identifier.

This PR:

  • Clarifies that users must keep an email address on their account at all times only when email address is the only enabled identifier.
  • Removes the verification requirement since that's dependent on instance settings

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@dstaley dstaley requested a review from a team as a code owner December 10, 2024 20:49
@github-actions GitHub Actions
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1793

alexisintech
alexisintech approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for clarifying this! 😸💖

@alexisintech alexisintech merged commit 40a06c6 into main Dec 11, 2024
3 checks passed
@alexisintech alexisintech deleted the ds.fix/email-reqs branch December 11, 2024 22:53
royanger pushed a commit that referenced this pull request Dec 16, 2024
@dstaley @victoriaxyz
@alexisintech @royanger
fix: clarify email address sign up requirements (#1793)
50977ec 
Co-authored-by: victoria <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexisintech alexisintech alexisintech approved these changes

@victoriaxyz victoriaxyz victoriaxyz approved these changes

Assignees
No one assigned
Labels
deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstaley @victoriaxyz @alexisintech