Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) align React and Vue docs; align prop/param descriptions #1814

Merged
merged 24 commits into from
Dec 19, 2024

Conversation

victoriaxyz
Copy link
Contributor

@victoriaxyz victoriaxyz commented Dec 16, 2024

  • fix code examples (e.g., missing chaining ops), filenames, code comments
  • add Returns and Params headings, and more descriptive example headings
  • replace all tables with <Properties /> table
  • align content, rewrite descriptions and intro paragraphs
  • remove More resources section

Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1814

docs/quickstarts/react.mdx Outdated Show resolved Hide resolved
docs/references/react/use-auth.mdx Outdated Show resolved Hide resolved
docs/references/react/use-auth.mdx Outdated Show resolved Hide resolved
docs/references/react/use-auth.mdx Outdated Show resolved Hide resolved
docs/references/react/use-auth.mdx Outdated Show resolved Hide resolved
docs/references/react/use-user.mdx Outdated Show resolved Hide resolved
docs/references/react/use-user.mdx Outdated Show resolved Hide resolved
docs/references/react/use-user.mdx Outdated Show resolved Hide resolved
docs/references/react/use-user.mdx Show resolved Hide resolved
docs/references/react/use-user.mdx Outdated Show resolved Hide resolved
@victoriaxyz victoriaxyz force-pushed the vi/align-react-vue-docs branch from 237ad8a to 68a0e44 Compare December 18, 2024 02:53

The following example demonstrates how to use the `useAuth()` hook to access the current auth state, like whether the user is signed in or not. It also demonstrates a basic example of how you could use the `getToken()` method to retrieve a session token for fetching data from an external resource.
The following example uses the `useAuth()` hook to fetch data from an external API using a session token. The `getToken()` method is used to retrieve the token.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still wouldn't say this is correct, as per my last comment:
You don't use useAuth() to fetch data using a session token. You use useAuth() to access the getToken() method, which gives you your session token. Then you can use your session token to fetch data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/references/react/use-clerk.mdx Outdated Show resolved Hide resolved

Use the `useSignUp()` hook to access the `SignUp` object and check the current state of a sign-up.
The following example uses the `useSignUp()` hook to access the [`SignUp`](/docs/references/javascript/sign-up/sign-up) object and check the current status of a sign-up.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make this match the usesignin() example description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexisintech alexisintech changed the title align React and Vue docs (chore) align React and Vue docs; align prop/param descriptions Dec 18, 2024
@alexisintech
Copy link
Member

we need to merge this PR: #1824 into this one

@victoriaxyz victoriaxyz merged commit 0635023 into main Dec 19, 2024
3 checks passed
@victoriaxyz victoriaxyz deleted the vi/align-react-vue-docs branch December 19, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants