-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: align reference headings, descriptions, structure #1815
Conversation
victoriaxyz
commented
Dec 16, 2024
•
edited
Loading
edited
- align descriptions, headings, intro paragraphs
- add intro sentence for server-side methods
- use partials for hooks
- remove next steps section
Hey, here’s your docs preview: https://clerk.com/docs/pr/1815 |
|
||
## Client-side helpers | ||
|
||
Because the Next.js SDK is built on top of the Clerk React SDK, you can utilize the hooks that the React SDK provides. These hooks give you access to the [`Clerk`](/docs/references/javascript/clerk/clerk) object and a set of useful helper methods for signing in and signing up. Learn more about these hooks in the [React SDK reference](/docs/references/react/overview). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this description is helpful because when the users click on the links to the hooks, they're going to be confused why they just got taken to the React SDK docs. For now, we need to keep this context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/references/nextjs/overview.mdx
Outdated
@@ -29,8 +29,6 @@ Clerk continues to provide drop-in support for the Next.js Pages Router. In addi | |||
- [`getAuth()`](/docs/references/nextjs/get-auth) | |||
- [`buildClerkProps()`](/docs/references/nextjs/build-clerk-props) | |||
|
|||
## Other references | |||
|
|||
### `Auth` object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this wouldn't be an h3 under "Server-side helpers" as its not a server-side helper, its an object.
same goes for clerkmiddleware - it wouldnt be an h3 under "server-side helpers" because its not a helper, its a middleware.
same goes for the demo repositories heading type (h3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
## Client-side helpers | ||
|
||
The Clerk React Router SDK is built on top of the Clerk React SDK and provides access to all of Clerk React's hooks. These hooks give you access to the [`Clerk`](/docs/references/javascript/clerk/clerk) object and a set of useful helper methods for signing in and signing up. Learn more about these hooks in the [React SDK reference](/docs/references/react/overview). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same note here about keeping this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -12,23 +12,13 @@ Clerk makes it simple to add authentication to your TanStack Start application. | |||
|
|||
## Client-side helpers | |||
|
|||
Because Clerk TanStack Start is a wrapper around Clerk React, you can utilize the hooks that Clerk React provides. These hooks give you access to the [`Clerk`](/docs/references/javascript/clerk/clerk) object, and a set of useful helper methods for signing in and signing up. You can learn more about these hooks [in the React SDK reference](/docs/references/react/overview). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same note about keeping the context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -23,7 +23,9 @@ Clerk Astro provides a set of useful [stores](https://github.com/nanostores/nano | |||
- [`$sessionListStore`](/docs/references/astro/session-list-store) | |||
- [`$organizationStore`](/docs/references/astro/organization-store) | |||
|
|||
## General Reference | |||
## Server-side helpers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the locals need to be added here, or somewhere on the page. Astro is on our list of going thru those docs and editing/validating them, but while we're here, we should do this right. we can pair on it if you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.