Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OKX Wallet Web3 authentication guide #1817

Merged
merged 4 commits into from
Dec 20, 2024
Merged

feat: OKX Wallet Web3 authentication guide #1817

merged 4 commits into from
Dec 20, 2024

Conversation

chanioxaris
Copy link
Member

@chanioxaris chanioxaris commented Dec 17, 2024 •
edited by victoriaxyz
Loading

Important

🔎 Previews:

Explanation:

This PR:

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@chanioxaris chanioxaris requested a review from a team as a code owner December 17, 2024 07:21
@github-actions GitHub Actions
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1817

victoriaxyz
victoriaxyz reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@victoriaxyz victoriaxyz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chanioxaris, here's my update: 6ecb504

  • mark "collect additional user information" section as optional and break down instructions into more granular steps
  • minor rewrite for grammar and style

@victoriaxyz victoriaxyz mentioned this pull request Dec 19, 2024
Merged
alexisintech
alexisintech approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@alexisintech alexisintech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!! 😸💖 feel free to merge when you're ready

@alexisintech alexisintech merged commit 411b22b into main Dec 20, 2024
4 checks passed
@alexisintech alexisintech deleted the haris/okx-wallet branch December 20, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoriaxyz victoriaxyz victoriaxyz left review comments

@alexisintech alexisintech alexisintech approved these changes

Assignees
No one assigned
Labels
deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chanioxaris @victoriaxyz @alexisintech