Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legalAcceptedAt and skipLegalChecks fields to user management methods #1828

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

NWylynko
Copy link
Contributor

@NWylynko NWylynko commented Dec 19, 2024

Explanation:

Updates the user object to include legalAcceptedAt and skipLegalChecks in the backend sdk to reflect the backend api.

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@NWylynko NWylynko requested a review from a team as a code owner December 19, 2024 15:10
@NWylynko NWylynko requested a review from royanger December 19, 2024 15:10
@royanger
Copy link
Member

@jeremy-clerk, I added you for a review as you originally reported this.

Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1828

Copy link
Member

@royanger royanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the return from clerkClient.users.updateUser() and clerkClient.users.updateUser() include legalAcceptedAt? I would expect it so we might need to update the console.log(response) on both of those pages.

@NWylynko
Copy link
Contributor Author

Does the return from clerkClient.users.updateUser() and clerkClient.users.updateUser() include legalAcceptedAt? I would expect it so we might need to update the console.log(response) on both of those pages.

Good catch! added :)

@alexisintech
Copy link
Member

hi friend! thanks so much for getting on this ticket.
we will need to update this page as well:

@NWylynko
Copy link
Contributor Author

Thanks for the feedback @alexisintech :) everything should be in order.

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks so much 😸💖

@alexisintech alexisintech merged commit d43786b into main Dec 19, 2024
3 checks passed
@alexisintech alexisintech deleted the nick/DOCS-9696 branch December 19, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants