Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-react): Render button components before clerk-js load #4810

Merged
merged 12 commits into from
Dec 20, 2024

Conversation

BRKalow
Copy link
Member

@BRKalow BRKalow commented Dec 18, 2024

Description

dependent on #4723

All of our button components currently delay rendering until after clerk-js has loaded. In practice, this is not necessary as IsomorphicClerk already handles buffering underlying clerk method calls before load. With this change, the button components will now always render. This should help address any layout shift caused by button component usage.

fixes SDKI-814

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: 14b79fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@clerk/clerk-react Minor
@clerk/chrome-extension Patch
@clerk/elements Patch
@clerk/clerk-expo Patch
@clerk/nextjs Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/tanstack-start Patch
@clerk/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 8:26pm

Base automatically changed from brk.feat/fallback-prop to main December 20, 2024 19:45
@BRKalow BRKalow marked this pull request as ready for review December 20, 2024 20:04
@BRKalow BRKalow merged commit b933a2b into main Dec 20, 2024
28 of 29 checks passed
@BRKalow BRKalow deleted the brk.feat/sign-in-up-out-buttons-render branch December 20, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants