Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable dependabot for github actions #54

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Conversation

v1v
Copy link
Contributor

@v1v v1v commented May 15, 2024

What

Enable dependabot for GitHub actions

Why

I've just discovered an action dependency a bit old

That has been annotated with a warning:

image

This should help with bumping versions in an automated manner :)

@v1v v1v requested a review from a team as a code owner May 15, 2024 07:43
@v1v v1v requested a review from williammartin May 15, 2024 07:43
Copy link
Contributor

@andyfeller andyfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v1v : thank you again for yet another contribution! 🫶

I'd like to get thoughts from @williammartin but these changes are solid as a whole.

Comment on lines +1 to +15
---
version: 2
updates:

# GitHub actions
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
day: "sunday"
time: "22:00"
groups:
github-actions:
patterns:
- "*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +6 to +11
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
day: "sunday"
time: "22:00"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williammartin : how consistently should Go and GitHub Actions dependabot PRs be across the cli repositories? how frequently do you expect to address updates?

I ask because cli/cli dependabot settings differ quite a bit and appreciate consistency:

version: 2
updates:
- package-ecosystem: gomod
  directory: "/"
  schedule:
    interval: "daily"
  ignore:
    - dependency-name: "*"
      update-types:
        - version-update:semver-minor
        - version-update:semver-major
- package-ecosystem: "github-actions"
  directory: "/"
  schedule:
      interval: "daily"

Between these changes and cli/cli, I think the groups usage could help cut down on churn of multiple PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants