Use Ruff instead of Black/isort/Flake8 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisp
force-pushed
the
ruff
branch
2 times, most recently
from
3b84575 to
201d823
Compare
sisp
changed the title
|
I think this PR is ready for a review now (after a few iterations 😉). |
timofurrer
approved these changes
Mar 25, 2024
|
@sisp looks good to me! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced Black, isort, and Flake8 by Ruff.
Ruff's config enables all linters except those that (a) would require manual changes to the code (which we can enable and resolve separately) or (b) conflict with Ruff's formatter. Regarding (b), I exclude the minimum set of rules such that the following statement in the docs holds:
I went for pinning Ruff's version because every release may change Ruff's expectations, so IMO we should update Ruff deliberately and resolve errors in the process. WDYT?
Closes #15 as a side-effect of removing Black.