move post migrate signals and autodiscover to edc_appconfig

edc_action_item/action_item_notification.py

@@ -2,7 +2,7 @@
 
 from django.core.exceptions import ObjectDoesNotExist
 from edc_constants.constants import CLOSED, NEW, OPEN
-from edc_notification import Notification
+from edc_notification.notification import Notification
 from edc_utils import get_utcnow
 
 NOTIFY_ON_NEW_AND_NO_REFERENCE_OBJ = "notify_on_new_and_no_reference_obj"

edc_action_item/apps.py

@@ -1,29 +1,11 @@
-import sys
-
 from django.apps import AppConfig as DjangoApponfig
 from django.core.management.color import color_style
-from django.db.models.signals import post_migrate
-
-from .site_action_items import site_action_items
 
 style = color_style()
 
 
-def update_action_types(sender=None, verbose=None, **kwargs):  # noqa
-    sys.stdout.write(style.MIGRATE_HEADING("Updating action types:\n"))
-    site_action_items.create_or_update_action_types()
-    sys.stdout.write("Done.\n")
-    sys.stdout.flush()
-
-
 class AppConfig(DjangoApponfig):
     name = "edc_action_item"
     verbose_name = "Action Items"
     has_exportable_data = True
     include_in_administration_section = True
-
-    def ready(self):
-        post_migrate.connect(update_action_types, sender=self)
-        sys.stdout.write(f"Loading {self.verbose_name} ...\n")
-        site_action_items.autodiscover()
-        sys.stdout.write(f" Done loading {self.verbose_name}.\n")

edc_action_item/auths.py

@@ -1,4 +1,4 @@
-from edc_auth.auth_objects import (
+from edc_auth.constants import (
     AUDITOR_ROLE,
     CLINICIAN_ROLE,
     CLINICIAN_SUPER_ROLE,

edc_action_item/models/signals.py

@@ -4,7 +4,7 @@
 from django.db.models.signals import m2m_changed, post_delete, post_save
 from django.dispatch import receiver
 from edc_constants.constants import CLOSED, NEW, OPEN
-from edc_notification import site_notifications
+from edc_notification.site_notifications import site_notifications
 from simple_history.signals import post_create_historical_record
 
 from ..utils import reset_and_delete_action_item

edc_action_item/post_migrate_signals.py

@@ -0,0 +1,14 @@
+import sys
+
+from django.core.management.color import color_style
+
+style = color_style()
+
+
+def update_action_types(sender=None, verbose=None, **kwargs):  # noqa
+    from .site_action_items import site_action_items
+
+    sys.stdout.write(style.MIGRATE_HEADING("Updating action types:\n"))
+    site_action_items.create_or_update_action_types()
+    sys.stdout.write("Done.\n")
+    sys.stdout.flush()

edc_action_item/site_action_items.py

@@ -9,8 +9,10 @@
 from django.apps import apps as django_apps
 from django.core.management.color import color_style
 from django.utils.module_loading import module_has_submodule
-from edc_notification import AlreadyRegistered as NotificationAlreadyRegistered
-from edc_notification import site_notifications
+from edc_notification.site_notifications import (
+    AlreadyRegistered as NotificationAlreadyRegistered,
+)
+from edc_notification.site_notifications import site_notifications
 from edc_prn.prn import Prn
 from edc_prn.site_prn_forms import AlreadyRegistered as PrnAlreadyRegistered
 from edc_prn.site_prn_forms import site_prn_forms
@@ -154,7 +156,7 @@ def autodiscover(module_name=None, verbose=True):
                 try:
                     before_import_registry = copy.copy(site_action_items.registry)
                     import_module(f"{app}.{module_name}")
-                    writer(f" * registered '{module_name}' from '{app}'\n")
+                    writer(f"   - registered '{module_name}' from '{app}'\n")
                 except SiteActionError as e:
                     writer(f"   - loading {app}.{module_name} ... ")
                     writer(style.ERROR(f"ERROR! {e}\n"))

edc_action_item/system_checks.py

@@ -1,16 +1,17 @@
-from django.core.checks import Warning, register
+from django.core.checks import Warning
 
-from edc_action_item.site_action_items import site_action_items
+from .site_action_items import site_action_items
 
 
-@register()
-def edc_notification_check(app_configs, **kwargs):  # noqa
+def edc_action_item_check(app_configs, **kwargs):
     errors = []
 
-    for action_cls in site_action_items.registry.items():
+    for name, action_cls in site_action_items.registry.items():
         try:
             action_cls.reference_model_cls().history
-        except AttributeError:
+        except AttributeError as e:
+            if "history" not in str(e):
+                raise
             errors.append(
                 Warning(
                     (

edc_action_item/tests/tests/test_action_notification.py

@@ -3,7 +3,7 @@
 from django.core import mail
 from django.test import TestCase
 from edc_constants.constants import NEW
-from edc_notification import NewModelNotification, UpdatedModelNotification
+from edc_notification.notification import NewModelNotification, UpdatedModelNotification
 from edc_notification.site_notifications import site_notifications
 
 from edc_action_item.action_item_notification import (