Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configless #57

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Configless #57

wants to merge 28 commits into from

Conversation

PuruVJ
Copy link
Contributor

@PuruVJ PuruVJ commented May 25, 2024

Similar to our Proposal folder's file structure

POC for configless docs. Contrary to the name, these are infact quite config heavy. But all configruation is now spread across the entire filesystem structure of the docs. The filesystem, the metadata in meta.json and at the top of .md files will inform the final URLs and navbar structure on the website.

@PuruVJ PuruVJ marked this pull request as ready for review September 21, 2024 13:43
@PuruVJ PuruVJ changed the title poc: Configless Configless Sep 23, 2024

### Binary Protocol

The SpacetimeDB binary WebSocket protocol, `v1.bin.spacetimedb`, encodes messages using [ProtoBuf 3](https://protobuf.dev), and reducer and row data using [BSATN](/docs/bsatn).
The SpacetimeDB binary WebSocket protocol, `v1.bin.spacetimedb`, encodes messages using [ProtoBuf 3](https://protobuf.dev), and reducer and row data using [BSATN](/docs/data-format/bsatn).

The binary protocol's messages are defined in [`client_api.proto`](https://github.com/clockworklabs/SpacetimeDB/blob/master/crates/client-api-messages/protobuf/client_api.proto).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is broken as we don't use protobufs anymore. What should this be replaced with?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we need to rewrite this whole page, pretty much. Perhaps we should replace it with a stub for now, and aim to rewrite it after all the WebSocket API changes we have planned.

Copy link
Contributor

@gefjon gefjon Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the JSON parts are also wrong now. I think we should replace this whole file with something like:

The SpacetimeDB WebSocket protocol is currently changing rapidly. Stay tuned for stable formats for the BSATN protocol v1.bin.spacetimedb and the JSON protocol v1.text.spacetimedb. For now, you can check the definition of the exchanged messages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Will do so in a separate PR after this

@cloutiertyler
Copy link
Contributor

@PuruVJ Spreading the config throughout the filesystem was how it used to be. We changed that (to copy the Bun structure) because it was very error prone. I don't think the meta.json file makes this better.

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Sep 23, 2024

What were the errors that could happen?

@cloutiertyler
Copy link
Contributor

People editing the docs were unaware of the equivalent of the .json files and the docs would get out of sync. Putting it in one place made that less likely, although did not eliminate it. I think configless is an improvement, but this is not configless IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants