FEAT: [k8scluster] support k8snodegroupDynamic #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokho-son
reviewed
Nov 19, 2024
| // @Success 200 {object} model.TbK8sNodeGroupInfo | ||
| // @Failure 404 {object} model.SimpleMsg | ||
| // @Failure 500 {object} model.SimpleMsg | ||
| // @Router /ns/{nsId}/k8scluster/{k8sClusterId}/k8snodegroupDynamic [post] |
There was a problem hiding this comment.
Suggested change
| // @Router /ns/{nsId}/k8scluster/{k8sClusterId}/k8snodegroupDynamic [post] | |
| // @Router /ns/{nsId}/k8scluster/{k8sClusterId}/k8sNodeGroupDynamic [post] |
need to keep api path lowerCamelCase for consistency.
(later, please check other API paths as well)
There was a problem hiding this comment.
관련 API path들을 검토하여 lowerCamelCase 형식으로 업데이트하였습니다.
o API changes
- (add) /ns/{nsId}/k8snodegroupDynamic
o others
- enable aws for k8scluster
- fix some bugs related to k8sclusterDynamic
- when creating shared subnets, try to assign different zone
- update API path as lowerCamelCase for consistency
sykim-etri
force-pushed
the
support-k8snodegroup-dynamic
branch
from
593ac94 to
6a17833
Compare
|
@sykim-etri Thank! |
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
본 PR은 k8sclusterDynamic API를 통해 생성한 k8scluster를 대상으로 k8snodegroup을 동적으로 생성할 수 있는 k8snodegroupDynamic API를 지원합니다.
o API changes
o others