Adds code to the repo #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vicente Zepeda Mas <[email protected]>
mukrishn
reviewed
Sep 18, 2024
Signed-off-by: Vicente Zepeda Mas <[email protected]>
dry923
reviewed
Sep 23, 2024
|
|
||
| echo "INFO: Patching the 4.17 Admin Acks" | ||
| echo "INFO: Check if we need them" | ||
| # oc -n openshift-config patch cm admin-acks --patch '{"data":{"ack-4.12-kube-1.26-api-removals-in-4.13":"true"}}' --type=merge |
There was a problem hiding this comment.
Theres a bunch of commented out code in this. Can we confirm what should be there still and what we can get rid of?
dry923
reviewed
Sep 23, 2024
|
|
||
| # Analize images | ||
| cd $rel_dir | ||
| # export IMAGES=$(cat image-references | jq -r '.spec.tags[].from.name' | sed 's/^/ - /; s/$/,/' | sed '$ s/,$//') |
There was a problem hiding this comment.
Theres a bunch of commented out code in this. Can we confirm what should be there still and what we can get rid of?
dry923
reviewed
Sep 23, 2024
| @@ -0,0 +1,27 @@ | |||
| {"data": [{"node": "CP-ip-10-0-4-119", "date_reported": "2024-08-30 12:55:39", "date_last_pull": "2024-08-30 12:55:34.341583069"}, | |||
There was a problem hiding this comment.
Is this file supposed to be an example of the output or ?
There was a problem hiding this comment.
This is used to generate the graphics on the Jupyter notebook.
dry923
reviewed
Sep 23, 2024
| @@ -0,0 +1,102 @@ | |||
| {"data": [ | |||
There was a problem hiding this comment.
Is this file supposed to be an example of the output or ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial code
Type of change
Description
Related Tickets & Documents
Checklist before requesting a review
Testing