Rds upgrade postgres for dev, stage and prod (#378)

* upgrading dev db to postgres 16.1

* updating staging db

* indenting build manifest and removing env: so the manifest formats correctly

* reverting changes to be added after build manifest PR

* changes to upgrade to Postgres16.1

* changing service var to be generic to allow for mysql, oracle or postgres testing

* missed main smoke test script for updating to use the new var

* missed one, added rds-service var to this test as well

* fixed typos for service names

* fixed more typos and missing parameters

* wacamole round 4, rds-service var was missing

* removed incorrect parameters to restaging

ci/pipeline.yml

@@ -40,8 +40,8 @@ jobs:
       TF_VAR_rds_internal_db_size: 20
       TF_VAR_rds_internal_db_name: ((development-rds-internal-db-name))
       TF_VAR_rds_internal_db_engine: postgres
-      TF_VAR_rds_internal_db_engine_version: 12
-      TF_VAR_rds_internal_db_parameter_group_family: postgres12
+      TF_VAR_rds_internal_db_engine_version: 16.1
+      TF_VAR_rds_internal_db_parameter_group_family: postgres16
       TF_VAR_rds_internal_multi_az: false
       TF_VAR_rds_internal_username: ((development-rds-internal-username))
       TF_VAR_rds_internal_password: ((development-rds-internal-password))
@@ -515,8 +515,8 @@ jobs:
       TF_VAR_rds_internal_db_size: 20
       TF_VAR_rds_internal_db_name: ((staging-rds-internal-db-name))
       TF_VAR_rds_internal_db_engine: postgres
-      TF_VAR_rds_internal_db_engine_version: 12
-      TF_VAR_rds_internal_db_parameter_group_family: postgres12
+      TF_VAR_rds_internal_db_engine_version: 16.1
+      TF_VAR_rds_internal_db_parameter_group_family: postgres16
       TF_VAR_rds_internal_multi_az: false
       TF_VAR_rds_internal_username: ((staging-rds-internal-username))
       TF_VAR_rds_internal_password: ((staging-rds-internal-password))
@@ -960,8 +960,8 @@ jobs:
       TF_VAR_rds_internal_db_size: 20
       TF_VAR_rds_internal_db_name: ((prod-rds-internal-db-name))
       TF_VAR_rds_internal_db_engine: postgres
-      TF_VAR_rds_internal_db_engine_version: 12
-      TF_VAR_rds_internal_db_parameter_group_family: postgres12
+      TF_VAR_rds_internal_db_engine_version: 16.1
+      TF_VAR_rds_internal_db_parameter_group_family: postgres16
       TF_VAR_rds_internal_multi_az: true
       TF_VAR_rds_internal_username: ((prod-rds-internal-username))
       TF_VAR_rds_internal_password: ((prod-rds-internal-password))