Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rds upgrade postgres #375

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Rds upgrade postgres #375

merged 4 commits into from
Sep 10, 2024

Conversation

rcgottlieb
Copy link
Contributor

Changes proposed in this pull request:

  • Updated the build-manifest to fix the formatting so deployments will work

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@rcgottlieb rcgottlieb requested a review from cweibel September 10, 2024 13:52
@rcgottlieb rcgottlieb requested a review from a team as a code owner September 10, 2024 13:52
Copy link
Contributor

@cweibel cweibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired with Robert on the debugging, this fixed dev.

The env: is already in the base manifest.yml file and needs to be properly indented when concatenated to the manifest otherwise the db host information won't be read in.

@rcgottlieb rcgottlieb added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 634abf1 Sep 10, 2024
1 check passed
@rcgottlieb rcgottlieb deleted the rds-upgrade-postgres branch September 10, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants