Code

Fix update retention logic#385

Code

Merged

markdboyd merged 9 commits intomaincloud-gov/aws-broker:mainfrom fix-update-retention-logiccloud-gov/aws-broker:fix-update-retention-logicCopy head branch name to clipboardNov 27, 2024

+171-52

Commits

Commits on Nov 25, 2024

• fix logic for validating RDS params to not allow a retention period less than the configuring minimum backup retention period

  markdboyd

  committed
  e1f3f5b

  Copy full SHA for e1f3f5b

• add more test cases

  markdboyd

  committed
  9bf38a6

  Copy full SHA for 9bf38a6

Commits on Nov 26, 2024

• add logic to ensure that backup retention cannot be less tha configured minimum retention on update

  markdboyd

  committed
  8614f44

  Copy full SHA for 8614f44

Commits on Nov 27, 2024

• change backup_retention_period update param to use pointer to separate the difference between nil and 0 as values

  markdboyd

  committed
  19c9378

  Copy full SHA for 19c9378

• update test to verify error is thrown when backup retention period of 0 is specified

  markdboyd

  committed
  5d90df9

  Copy full SHA for 5d90df9

• fix invalid pointer reference

  markdboyd

  committed
  26cf1a3

  Copy full SHA for 26cf1a3

• update expected property for test

  markdboyd

  committed
  f44c179

  Copy full SHA for f44c179

• add more test cases

  markdboyd

  committed
  1f4e024

  Copy full SHA for 1f4e024

• update org name in github repo from 18F -> cloud-gov

  markdboyd

  committed
  a457429

  Copy full SHA for a457429