Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix instance types of log group fields #392

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • fix instance types of log group fields on instance structs so that they are actually saved to the database

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just making sure that fields get written to the database rather than ignored

@markdboyd markdboyd requested a review from a team as a code owner December 19, 2024 17:02
@markdboyd markdboyd added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 4200ba5 Dec 19, 2024
1 check passed
@markdboyd markdboyd deleted the fix-instance-sql-types branch December 19, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants