Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating for container hardening #2

Merged
merged 1 commit into from
Apr 23, 2024
Merged

updating for container hardening #2

merged 1 commit into from
Apr 23, 2024

Conversation

dandersonsw
Copy link

Changes proposed in this pull request:

  • Use hardened base container image
  • Add security-considerations.md file
  • Update Go version
  • Remove CI directory as it is not needed

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Setting up this repo for container hardening

@dandersonsw dandersonsw requested a review from a team April 23, 2024 19:40

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these files being deleted?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are the files used by the cloudfoundry org for their pipelines, so they do not apply to us.

@dandersonsw dandersonsw merged commit 1a27b71 into main Apr 23, 2024
1 check passed
@dandersonsw dandersonsw deleted the harden-image branch April 23, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants