Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use golang-builder like other concourse resources now do #3

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

dandersonsw
Copy link

Changes proposed in this pull request:

  • Updates the dockerfile to use the golang-builder image to actually compile the commands. Concourse switched to this method for the resource repos, but this one was never updated to follow this new method

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Setting up the code to properly compile

@dandersonsw dandersonsw requested a review from a team April 24, 2024 15:07
Copy link

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dandersonsw dandersonsw merged commit f5942b3 into main Apr 24, 2024
2 checks passed
@dandersonsw dandersonsw deleted the update-dockerfile branch April 24, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants