Update to support Django 4 #71
Conversation
pyproject.toml
Outdated
| @@ -27,30 +27,16 @@ exclude = ''' | |||
| [tool.tox] | |||
| legacy_tox_ini = """ | |||
| [tox] | |||
| envlist = py35-django22,py3{6,7,8,9,10}-django{22,30,31,32} | |||
| envlist = py3{8,9,10,11,12}-django{40,41,42} | |||
There was a problem hiding this comment.
Are there any customers running apps based on python 3.6 or 3.7 using the django pack that would run into issues deprecating this? We haven't communicated our deprecations well enough to just shut them down IMO.
There was a problem hiding this comment.
That's fair. We're just removing tests for Python 3.6/3.7 in this case, not actually deprecating support, but i can re-add.
There was a problem hiding this comment.
To be more clear: these changes don't actually deprecate support for Python 3.6/3.7, they just update our unit tests to drop testing for those environments. Someone could still install this package on Python 3.6/3.7, we just wouldn't have unit tests any more verifying that this package works on those versions.
Also, Python 3.6/3.7 are officially end-of-life and no longer supported or receiving security updates: https://devguide.python.org/versions/, so it seems safe to drop our testing for those versions?
There was a problem hiding this comment.
Ah, okay. If they are EOL'ed then that seems safe to drop them.
pyproject.toml
Outdated
| isolated_build=true | ||
|
|
||
| [testenv:py3{5,6,7}] | ||
| [testenv:py3{8,9,10,11,12}] |
| Framework :: Django :: 3.0 | ||
| Framework :: Django :: 3.1 | ||
| Framework :: Django :: 3.2 | ||
| Framework :: Django :: 4.0 |
There was a problem hiding this comment.
There are others using Django pack on the platform that are likely on older versions. Do we need a comms and deprecation process to get folks to move to newer versions?
I'm mostly concerned that we're deprecating apps using older versions without alerting folks to move forward so if folks try to stage anything they won't successfully deploy.
There was a problem hiding this comment.
Since this package has different released versions, if someone still needs to keep using an older version of Django, they can pin their dependency to an older release of this package
There was a problem hiding this comment.
👍 Just wanted to make sure we're not cutting folks off from using this without comms to the customers about what dependencies are going away and some lead time to make changes.
Closes #70
Changes proposed in this pull request:
djangodependency to>=4.0,<5.0security considerations
There is no sensitive material in these updates. Just updating the code to support Django 4