Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade Pages to USWDS V3 #4603

Merged
merged 1 commit into from
Oct 2, 2024
Merged

feat: Upgrade Pages to USWDS V3 #4603

merged 1 commit into from
Oct 2, 2024

Conversation

sknep
Copy link
Contributor

@sknep sknep commented Sep 19, 2024 •
edited by apburnes
Loading

Closes #4595
Closes #4609

Changes proposed in this pull request:

  • Upgrades to USWDS V3 for both the platform and admin apps
  • Moves to a single webpack config for all environments
  • Removes old versions of USWDS that were copied into the public folder

security considerations

  • none, mostly css and class fixes
  • Upgrades to latest USWDS v3

@sknep sknep force-pushed the feat-upgraded-uswds-v3-styles branch 3 times, most recently from 80d66c1 to 794b472 Compare September 24, 2024 23:05
@apburnes apburnes force-pushed the feat-upgraded-uswds-v3-styles branch 5 times, most recently from 9bbafbb to c5297ea Compare September 26, 2024 20:09
@apburnes apburnes changed the title [WIP] Upgrade Pages to USWDS V3 feat: Upgrade Pages to USWDS V3 Sep 26, 2024
drewbo
drewbo requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@drewbo drewbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I noticed:

Blocking:

  • The settings navigation is gone from the top right

You decide how notable these are:

  • Every page now has the "back to top" link but it's outside the "normal layout" flow
  • The individual user rows on the organization edit page are big because the buttons are no longer inline
Screenshot 2024-10-01 at 12 09 36 PM
  • Adding a new custom domain, the input box is oddly small
Screenshot 2024-10-01 at 12 11 57 PM

@sknep sknep requested a review from drewbo October 1, 2024 21:52
drewbo
drewbo previously approved these changes Oct 2, 2024
View reviewed changes
@drewbo drewbo self-requested a review October 2, 2024 18:46
@sknep sknep force-pushed the feat-upgraded-uswds-v3-styles branch from 6ba8641 to e60ad4d Compare October 2, 2024 21:10
@sknep sknep merged commit 5e31234 into main Oct 2, 2024
8 checks passed
@sknep sknep deleted the feat-upgraded-uswds-v3-styles branch October 2, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbo drewbo drewbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sknep @drewbo @apburnes