Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolved id vs name usage and fixed non-unique task names in pipeline. #47

Merged
merged 4 commits into from
Jun 17, 2024
Merged

fix: resolved id vs name usage and fixed non-unique task names in pipeline. #47

merged 4 commits into from
Jun 17, 2024

Conversation

snehajais22
Copy link
Collaborator

No description provided.

nathanagood
nathanagood approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@nathanagood nathanagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

I really like the "binding" nomenclature for the workspaces and also the clarity (including comment updates) of name v. logical ID where it's important.

@nathanagood nathanagood merged commit 46b22ff into develop Jun 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanagood nathanagood nathanagood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snehajais22 @nathanagood