Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudant update setup logic #11

Open
wants to merge 2 commits into
base: cloudant
Choose a base branch
from

Conversation

chewbranca
Copy link
Member

We should be loading configs in setup_benchmark rather than run_benchmark so that everything necessary to run the benchmark is prepared in setup. This makes it very handy for testing out various driver functions without having to run a proper benchmark.

Having to pass the configs into run_benchmark as well is a bit awkward, but it kind of makes sense as loading the config is a different action than copying the config into the log directory for actually running the benchmark. I'm open to alternative suggestions, but I think this is fine for a first pass, especially since it allows us to develop drivers interactively.

@MatthiasLeeIBM
Copy link

How about adding something that allows us to do both the setup and start the run.

setup_run_benchmark(Opts, Configs) ->
    setup_benchmark(Opts, Configs),
    run_benchmark(Configs).

also looking for a way to exit after completion..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants