Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVY-356 Enabling LDAP authentication for Client to Server. #343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakhani
Copy link

@jakhani jakhani commented Jun 15, 2017

Currently, Livy doesn't support LDAP Authentication from client(sparkmagic) to server(livy). We need to add LDAP authentication as that's preferable method due to security reasons. We won't be able to use Knox for this purpose. That is why I am raising this PR which contains LDAP authentication.

I am also adding config to disable batch endpoints. Due to security reasons, we don't want to keep batch endpoint open. I am adding config so that We can disable it.

@codecov-io
Copy link

Codecov Report

Merging #343 into master will decrease coverage by 1.37%.
The diff coverage is 13.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #343      +/-   ##
============================================
- Coverage     70.63%   69.25%   -1.38%     
- Complexity      730      732       +2     
============================================
  Files            96       97       +1     
  Lines          5153     5283     +130     
  Branches        776      796      +20     
============================================
+ Hits           3640     3659      +19     
- Misses          996     1105     +109     
- Partials        517      519       +2
Impacted Files Coverage Δ Complexity Δ
...er/src/main/scala/com/cloudera/livy/LivyConf.scala 94.61% <100%> (+0.26%) 16 <0> (ø) ⬇️
...in/scala/com/cloudera/livy/server/LivyServer.scala 34.44% <15.78%> (-2.98%) 9 <0> (ø)
...vy/server/auth/LdapAuthenticationHandlerImpl.scala 8.41% <8.41%> (ø) 0 <0> (?)
.../java/com/cloudera/livy/rsc/driver/JobWrapper.java 80.64% <0%> (ø) 8% <0%> (+1%) ⬆️
...n/java/com/cloudera/livy/rsc/driver/RSCDriver.java 78.87% <0%> (+1.29%) 42% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae24d0...15b1495. Read the comment docs.

@jakhani
Copy link
Author

jakhani commented Jun 15, 2017

@jerryshao Can you please review this PR? I have discarded old PR for LDAP as this is better solution.

@jerryshao
Copy link
Contributor

Sorry @jakhani for the delay, we're working on migrating Livy project to ASF, It would be better to wait for while and send PR against in new repo. Really sorry about the delay.

@jerryshao
Copy link
Contributor

Hi @jakhani can you please submit this PR against incubator-livy (https://github.com/apache/incubator-livy/pulls), thanks!

@jakhani
Copy link
Author

jakhani commented Jun 30, 2017

@jerryshao I will raise PR and let you know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants