Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make library AOT compatible #272

Open
giggio opened this issue Oct 18, 2023 · 5 comments · May be fixed by #273
Open

Make library AOT compatible #272

giggio opened this issue Oct 18, 2023 · 5 comments · May be fixed by #273
Labels
help wanted Extra attention is needed

Comments

@giggio
Copy link

giggio commented Oct 18, 2023

Right now we are getting warnings, like:

/home/user/.nuget/packages/cloudnative.cloudevents.systemtextjson/2.7.1/lib/netstandard2.1/CloudNative.CloudEvents.SystemTextJson.dll : warning IL2104: Assembly 'CloudNative.CloudEvents.SystemTextJson' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [/app/consumer.csproj]
/home/user/.nuget/packages/cloudnative.cloudevents.systemtextjson/2.7.1/lib/netstandard2.1/CloudNative.CloudEvents.SystemTextJson.dll : warning IL3053: Assembly 'CloudNative.CloudEvents.SystemTextJson' produced AOT analysis warnings. [/app/consumer.csproj]
@jskeet jskeet added the help wanted Extra attention is needed label Oct 18, 2023
@jskeet
Copy link
Contributor

jskeet commented Oct 18, 2023

I'm afraid I don't have enough experience with AOT (or time to get up to speed) to work on this. I'd happily review a PR to address it, however.

@giggio giggio linked a pull request Nov 11, 2023 that will close this issue
Open
@giggio
Copy link
Author

giggio commented Nov 11, 2023

@jskeet I just added a PR for it, it was a lot of work, I need revision to make sure everything is ok.

@jskeet jskeet mentioned this issue Nov 15, 2023
Merged
@guillaume-chervet
Copy link

hi @jskeet , does this library is AOT compatible now?

I would like to use it for a test as an extention for https://github.com/AxaFrance/SlimFaas

@jskeet
Copy link
Contributor

jskeet commented Aug 21, 2024

@guillaume-chervet: No, it isn't. There's an incomplete attempt in https://github.com/jskeet/sdk-csharp/tree/aot - it's possible that we could do this incrementally, but for the moment I'm afraid I don't have time to put into it. @captainsafia has expressed interest though, and can probably do a better job on this than I can anyway.

@guillaume-chervet
Copy link

Thank you @jskeet for your "very" quick answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add .NET 7, 8, trimming and AOT support giggio/cloudevents-sdk-csharp
3 participants
@jskeet @giggio @guillaume-chervet