Upgrade to .NET SDK 8.0 #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - Adds a global.json file to declare the required SDK version - Updates CI to install both .NET 6 and .NET 8 - Updates the test projects to test with both .NET 6 and .NET 8 Signed-off-by: Jon Skeet <[email protected]>
This commit *just* adds .NET 8 to the target framework list, in all packages. The code will not build at this point, due to nullability checking. That will be fixed in a later commit, but separating the two makes it easier to review. Later we may well decided to *build* a .NET 8 target, but not pack it - unless we see concrete benefits from doing so over letting .NET 8 use the existing netstandard2.1 target. Signed-off-by: Jon Skeet <[email protected]>
Signed-off-by: Jon Skeet <[email protected]>
Signed-off-by: Jon Skeet <[email protected]>
JoshLove-msft
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was originally intending not to actually target net8.0 in the nuget package itself, but given that it gets rid of the System.Memory dependency and it's much simpler in terms of not having to exclude it, I think this is the way to go.
No behavioral changes in this PR, except for some potentially pathological cases (where the new behavior is better).
This is one step towards #272.