Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RabbitMQ bindings #311

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

antiblue
Copy link

PR for #310
Adds AMQP 0.9.1 protocol binding using the RabbitMq.Client.

It follows the "RabbitMQ Protocol Binding for CloudEvents" specification.

@jskeet jskeet self-assigned this Sep 19, 2024
@jskeet
Copy link
Contributor

jskeet commented Sep 19, 2024

Will try to review this next week.

@clemensv
Copy link
Contributor

clemensv commented Sep 19, 2024

There is no spec'd protocol binding for AMQP 0.9.1. AMQP 0.9.1 is an expired draft of the AMQP protocol and never made it to standardization. That excludes AMQP 0.9.1 per https://github.com/cloudevents/spec/blob/main/cloudevents/primer.md#qualifying-protocols-and-encodings

What can be done is to submit a binding spec into the "proprietary specs" section for RabbitMQ analog to RocketMQ.
https://github.com/cloudevents/spec/blob/main/cloudevents/proprietary-specs.md

That can then be composed with, but arguably not embedded into the official SDK.

Edit: I only just see that the RMQ binding exists but isn't registered in our proprietary spec list. That should be added. Still skeptical whether a proprietary client should be in the offical SDK.

@antiblue
Copy link
Author

antiblue commented Sep 19, 2024

Still skeptical whether a proprietary client should be in the offical SDK.

That is a valid point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants