fix: LIKE expression with invalid string literals returns a parse error instead of panicking #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duglin
reviewed
May 3, 2024
|
Aside from my minor question, LGTM |
pierDipi
reviewed
May 9, 2024
This was referenced May 9, 2024
test: verify that invalid string literals in LIKE expression are a parse error
cloudevents/spec#1280
Merged
|
cc @embano1 |
|
do we have a testcase for this? |
@duglin yes, the new tck test in this PR runs and passes with this change, but prior to the change it would panic |
lionelvillard
approved these changes
Jun 11, 2024
|
@duglin for final approval/merge |
…or instead of panic Signed-off-by: Calum Murray <[email protected]>
duglin
force-pushed
the
fix-like-expression-panic-on-parse
branch
from
6f1b2c3
to
3e20125
Compare
|
LGTM - it needed a rebase so kicked that off... |
|
merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #931
When visiting the nodes of the AST while parsing the LIKE expression, it looks like we assumed that we would have a valid string literal. However, it is possible that there is no valid string literal, in which case we have to handle that and return an error rather than continuing to parse (and subsequently panicking)