-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Customizing Cloudevents validation #594
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
13de314
feat: Customizing Cloudevents validation
4588166
Add link to CloudEvent security mailing list (#599)
duglin 977e846
feat: Customizing Cloudevents validation
c92553c
feat: Customizing Cloudevents validation
62c55e7
Update cesql TCK tests (#603)
Cali0707 8c66b1b
feat: Customizing Cloudevents validation
2cc7b78
Merge branch 'cloudevents:main' into cloudevents-validation
touchkey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
52 changes: 52 additions & 0 deletions
52
core/src/main/java/io/cloudevents/core/provider/CloudEventValidatorProvider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Copyright 2018-Present The CloudEvents Authors | ||
* <p> | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* <p> | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* <p> | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
package io.cloudevents.core.provider; | ||
|
||
import io.cloudevents.CloudEvent; | ||
import io.cloudevents.core.validator.CloudEventValidator; | ||
|
||
import java.util.Iterator; | ||
import java.util.ServiceConfigurationError; | ||
import java.util.ServiceLoader; | ||
|
||
/** | ||
* CloudEventValidatorProvider is a singleton class which loads and access CE Validator service providers on behalf of service clients. | ||
*/ | ||
public class CloudEventValidatorProvider { | ||
|
||
private static final CloudEventValidatorProvider cloudEventValidatorProvider = new CloudEventValidatorProvider(); | ||
|
||
private final ServiceLoader<CloudEventValidator> loader; | ||
|
||
private CloudEventValidatorProvider(){ | ||
loader = ServiceLoader.load(CloudEventValidator.class); | ||
} | ||
|
||
public static CloudEventValidatorProvider getInstance() { | ||
return cloudEventValidatorProvider; | ||
} | ||
|
||
/** | ||
* iterates through available Cloudevent validators. | ||
* @param cloudEvent | ||
*/ | ||
public void validate(CloudEvent cloudEvent){ | ||
for (final CloudEventValidator validator : loader) { | ||
validator.validate(cloudEvent); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
core/src/main/java/io/cloudevents/core/validator/CloudEventValidator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright 2018-Present The CloudEvents Authors | ||
* <p> | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* <p> | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* <p> | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
*/ | ||
package io.cloudevents.core.validator; | ||
|
||
import io.cloudevents.CloudEvent; | ||
|
||
/** | ||
* @author Vinay Bhat | ||
* Interface which defines validation for CloudEvents attributes and extensions. | ||
*/ | ||
public interface CloudEventValidator { | ||
|
||
/** | ||
* Validate the attributes of a CloudEvent. | ||
* | ||
* @param cloudEvent the CloudEvent to validate | ||
*/ | ||
void validate(CloudEvent cloudEvent); | ||
} |
17 changes: 17 additions & 0 deletions
17
core/src/test/java/io/cloudevents/core/test/CloudEventCustomValidator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package io.cloudevents.core.test; | ||
|
||
import io.cloudevents.CloudEvent; | ||
import io.cloudevents.core.validator.CloudEventValidator; | ||
|
||
public class CloudEventCustomValidator implements CloudEventValidator { | ||
|
||
@Override | ||
public void validate(CloudEvent cloudEvent) { | ||
String namespace = null; | ||
if ((namespace = (String) cloudEvent.getExtension("namespace")) != null && | ||
!namespace.equals("sales")){ | ||
throw new IllegalStateException("Expecting sales in namespace extension"); | ||
} | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
core/src/test/resources/META-INF/services/io.cloudevents.core.validator.CloudEventValidator
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
io.cloudevents.core.test.CloudEventCustomValidator |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.