-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Adding changelog for node compat improvements #19341
base: production
Are you sure you want to change the base?
Conversation
TODO: * Add docs and proper links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 2 total issue(s) found.
import { Render, PackageManagers, TypeScriptExample } from "~/components" | ||
|
||
<!-- TODO: Add these docs --> | ||
When using a worker with [nodejs_compatability](/workers/runtime-apis/nodejs/) enabled, you can now use the following Node.js APIs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using a worker with [nodejs_compatability](/workers/runtime-apis/nodejs/) enabled, you can now use the following Node.js APIs: | |
When using a Worker with [nodejs_compatability](/workers/runtime-apis/nodejs/) enabled, you can now use the following Node.js APIs: |
Issues:
- Style Guide - (Terms-error) Use 'Worker' instead of 'worker'.
Fix Explanation:
The term 'worker' should be capitalized to 'Worker' to adhere to the style guide, as it likely refers to a specific product or service name.
|
||
You can use [`net.Socket`](https://nodejs.org/api/net.html#class-netsocket) to create a direct connection to a server via a TCP socket. | ||
This can be useful when connecting to databases such as MySQL or PostgreSQL, though if possible, using | ||
[Hyperdrive Connection Pooling](https://developers.cloudflare.com/hyperdrive/configuration/how-hyperdrive-works/#connection-pooling) is preferable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Hyperdrive Connection Pooling](https://developers.cloudflare.com/hyperdrive/configuration/how-hyperdrive-works/#connection-pooling) is preferable. | |
[Hyperdrive Connection Pooling](/hyperdrive/configuration/how-hyperdrive-works/#connection-pooling) is preferable. |
Issues:
- Style Guide - (cloudflare.LinkChecks-warning) Warning: When referring to another page in our docs, use the full relative link (
/1.1.1.1/check/
) instead of the full URL (https://developers.cloudflare.com/1.1.1.1/check/
) or a local development link (http://localhost:111/1.1.1.1/check/
).
Fix Explanation:
The link was changed from a full URL to a relative link as per the style guide recommendation. This ensures that the documentation remains consistent and adaptable to changes in the base URL.
``` | ||
|
||
Note that due to [security-based restrictions on timers](/workers/reference/security-model/#step-1-disallow-timers-and-multi-threading) in Workers, | ||
timers are limited to returning the time of the last I/O. This means that while setTimeout and setInterval will defer your function execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timers are limited to returning the time of the last I/O. This means that while setTimeout and setInterval will defer your function execution | |
timers are limited to returning the time of the last I/O. This means that while setTimeout, setInterval and setImmediate will defer your function execution |
TODO:
Summary
Screenshots (optional)
Documentation checklist