Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test coverage for checkstyle #1145

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Add more test coverage for checkstyle #1145

merged 1 commit into from
Oct 10, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.66.1-10-gf9e586f
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Oct 10, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.70m ± 5%   39.66m ± 1%       ~ (p=0.315 n=10)
CheckRules-4     8.503 ± 2%    8.521 ± 2%       ~ (p=0.481 n=10)
geomean         581.0m        581.3m       +0.05%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.41Mi ± 0%       ~ (p=0.143 n=10)
CheckRules-4    977.5Mi ± 0%   977.0Mi ± 0%       ~ (p=0.280 n=10)
geomean         163.7Mi        163.6Mi       -0.02%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.9k ± 0%   131.9k ± 0%  +0.00% (p=0.032 n=10)
CheckRules-4    14.19M ± 0%   14.19M ± 0%       ~ (p=0.247 n=10)
geomean         1.368M        1.368M       -0.01%

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 95.13%. Comparing base (f01f208) to head (f9e586f).

Files with missing lines Patch % Lines
internal/reporter/checkstyle.go 66.66% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
+ Coverage   95.01%   95.13%   +0.11%     
==========================================
  Files         103      103              
  Lines       10355    10350       -5     
==========================================
+ Hits         9839     9846       +7     
+ Misses        360      351       -9     
+ Partials      156      153       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 17371fe into main Oct 10, 2024
20 checks passed
@prymitive prymitive deleted the checkstyle branch October 10, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants