BBR2 - Fixes and updates #1521
Closed
BBR2 - Fixes and updates #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass a whole lost packet (Sent) to congestion_event() hook, to use some of the information of lost packet.
This is needed in BBR2 module.
ghedo
force-pushed
the
bbr2_enhance
branch
2 times, most recently
from
94dd685
to
0248838
Compare
{Sent|Acked}.{tx_in_flight|lost} is current bytes_in_flight
and bytes_lost counter when the packet is sent.
This is needed for BBR2 module.
Based on draft-cardwell-iccrg-bbr-congestion-control-02. Largely based on bbr module but most of functions are renamed/changed a bit. per_loss.rs contains loss-related functions.
|
FTR, this is based on top of #1218. |
divyabhat1
force-pushed
the
bbr2_enhance
branch
from
07a2c3c
to
93808bd
Compare
quiche/src/recovery/bbr2/per_ack.rs
Outdated
|
|
||
| fn bbr2_handle_queue_too_high_in_startup(r: &mut Recovery) { | ||
| r.bbr2_state.filled_pipe = true; | ||
| bbr2_inflight(r, r.bbr2_state.max_bw, 1.0); |
There was a problem hiding this comment.
From the Linux implementation, we need to assign the calculated inflight to inflight_hi variable which is part of long term model.
There was a problem hiding this comment.
good catch! Updated. Thanks :)
quiche/src/recovery/bbr2/per_ack.rs
Outdated
| // Another round w/o much growth | ||
| r.bbr2_state.full_bw_count += 1; | ||
|
|
||
| if r.bbr2_state.full_bw_count >= 3 { |
There was a problem hiding this comment.
Move 3 into a constant
Pass a whole lost packet (Sent) to congestion_event() hook, to use some of the information of lost packet.
This is needed in BBR2 module.
{Sent|Acked}.{tx_in_flight|lost} is current bytes_in_flight
and bytes_lost counter when the packet is sent.
This is needed for BBR2 module.
Based on draft-cardwell-iccrg-bbr-congestion-control-02. Largely based on bbr module but most of functions are renamed/changed a bit. per_loss.rs contains loss-related functions.
…correct bytes_in_flight
divyabhat1
force-pushed
the
bbr2_enhance
branch
from
93808bd
to
8680b1d
Compare
ghedo
force-pushed
the
1512.bbr2
branch
2 times, most recently
from
f7bb08e
to
dbc5eb8
Compare
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG FIXES
minRTTis never updated unless a smaller value is measuredEDITS OBTAINED FROM LINUX IMPLEMENTATION OF BBRV2
MY EDITS
MinRTT,MaxBWand ACK aggregation - all windows updated to use a function of RTT, instead of static values (currently uses the most recent value to account for transient network variations, should optimize)ProbeRTTphase. ProbeRTT was defined in the draft to probe the path for bandwidth during a session (long-lived sessions would benefit). It reduces bytes in flight in order to probe for RTT, needs more work to figure out when we do this.