qlog: Add explicit lifetime parameter to QlogSeqReader #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding an explicit lifetime parameter to QlogSeqReader the lifetime of the Box'd BufReader's inner does not need to be 'static.
|
I had great trouble instantiating a QlogSeqReader because of the generic lifetime of the struct -- the compiler was not able to deduce the relationship between lifetimes and insisted that I had references to objects that did not live long enough. I hope that this is helpful to someone else! |
ghedo
approved these changes
Oct 22, 2024
|
Merged, thanks @hawkinsw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding an explicit lifetime parameter to QlogSeqReader the lifetime of the Box'd BufReader's inner does not need to be 'static.