[nfc] 110824 assorted build cleanup #3085
Merged
+220
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The rules_rust update includes checksums for Rust 1.82, fixing a warning.
- Add missing includes for absl, cxx_integration - Fix boringssl include after last update - Move sqlite3 include so our generated header is used, not the system version - Drop superfluous /usr/local/include include
anonrig
approved these changes
Nov 10, 2024
|
ASAN errors might be related |
Thank you for approving. The crash disappears after re-running the ASan job, so it is unlikely to be caused by this (there are two libc++ flags being added but they are unrelated to ASan and are working well with downstream). There is a downstream V8 patch dealing with ASan issues for html-rewriter tests, perhaps the html-rewriter crash here has the same root cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll Rust deps, rules_rust
[build] Fix protobuf warning, compile_flags.txt
[build] Port libc++ defines from downstream to reduce include overhead