[o11y] Provide OTel-compatible user span representation in trace #3180
Conversation
fhanau
force-pushed
the
felix/111524-user-tracing-otel-v1
branch
2 times, most recently
from
20b2330 to
e5764c6
Compare
fhanau
force-pushed
the
felix/111524-user-tracing-otel-v1
branch
from
e5764c6 to
c3f12ae
Compare
|
This should be ready for review now – I'm not 100% certain about the span representation but we can still change it while this is marked as experimental. Making trace spans available is covered in a follow-up PR (#3209), I fear that it will require some more review so not including it in this one. |
| kj::String spanTagStr(const Span::TagValue& tag); | ||
| Span::TagValue spanTagClone(const Span::TagValue& tag); | ||
|
|
||
| struct CompleteSpan { |
There was a problem hiding this comment.
Not sure if CompleteSpan is descriptive enough. Should this be UserSubmitSpan or something else? It's unfortunate that we'll need this on top of Span, but this needs to store more information than Span has.
|
|
Hoping to get reviews on this soon – this will be useful for doing another demo on user tracing using the new interchange format. |
fhanau
force-pushed
the
felix/111524-user-tracing-otel-v1
branch
from
c3f12ae to
d2c39ba
Compare
|
The generated output of |
fhanau
force-pushed
the
felix/111524-user-tracing-otel-v1
branch
from
d2c39ba to
598986f
Compare
fhanau
force-pushed
the
felix/111524-user-tracing-otel-v1
branch
from
598986f to
956a297
Compare
#3177 should land before this (listed as the first comment here). Also see the corresponding upstream PR.