Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[o11y] Add KV span tags #3261

Merged
merged 2 commits into from
Jan 8, 2025
Merged

[o11y] Add KV span tags #3261

merged 2 commits into from
Jan 8, 2025

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Dec 20, 2024

#3256 needs to land first.

@fhanau fhanau requested a review from mikea December 20, 2024 01:25
@fhanau fhanau requested review from a team as code owners December 20, 2024 01:25
@fhanau fhanau requested a review from tewaro December 20, 2024 01:25
@fhanau fhanau force-pushed the felix/subrequest-client-spans-kv branch from 04c7f43 to 076a736 Compare December 20, 2024 01:31
@fhanau fhanau force-pushed the felix/subrequest-client-spans-kv branch from 076a736 to 0d0a53f Compare December 20, 2024 15:59
@fhanau fhanau force-pushed the felix/subrequest-client-spans-kv branch from 0d0a53f to e182c52 Compare December 31, 2024 00:14
Copy link
Collaborator

@mikea mikea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sequences of very similar literals are not the best, otherwise lg.

src/workerd/api/r2-bucket.c++ Outdated Show resolved Hide resolved
@fhanau fhanau force-pushed the felix/subrequest-client-spans-kv branch from e182c52 to b48a847 Compare December 31, 2024 19:09
Copy link

github-actions bot commented Dec 31, 2024

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@fhanau fhanau force-pushed the felix/subrequest-client-spans-kv branch from b48a847 to 0b852c0 Compare January 8, 2025 16:04
@fhanau fhanau merged commit 827685a into main Jan 8, 2025
15 checks passed
@fhanau fhanau deleted the felix/subrequest-client-spans-kv branch January 8, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants