-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[o11y] Add KV span tags #3261
Merged
Merged
[o11y] Add KV span tags #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/subrequest-client-spans-kv
branch
from
December 20, 2024 01:31
04c7f43
to
076a736
Compare
fhanau
commented
Dec 20, 2024
fhanau
commented
Dec 20, 2024
fhanau
force-pushed
the
felix/subrequest-client-spans-kv
branch
from
December 20, 2024 15:59
076a736
to
0d0a53f
Compare
fhanau
force-pushed
the
felix/subrequest-client-spans-kv
branch
from
December 31, 2024 00:14
0d0a53f
to
e182c52
Compare
mikea
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sequences of very similar literals are not the best, otherwise lg.
fhanau
force-pushed
the
felix/subrequest-client-spans-kv
branch
from
December 31, 2024 19:09
e182c52
to
b48a847
Compare
The generated output of |
jasnell
approved these changes
Jan 2, 2025
fhanau
force-pushed
the
felix/subrequest-client-spans-kv
branch
from
January 8, 2025 16:04
b48a847
to
0b852c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3256 needs to land first.