Skip to content

Commit

Permalink
C3: Defaulting project type to webFramework (#4062)
Browse files Browse the repository at this point in the history
* C3: Defaulting project type to webFramework

* Fixing cli e2e tests
  • Loading branch information
jculvey authored Oct 3, 2023
1 parent 3127071 commit 02359bc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/khaki-experts-reflect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-cloudflare": patch
---

Defaults the project type to `Web Framework`. The previous default was `"Hello World" worker`
6 changes: 3 additions & 3 deletions packages/create-cloudflare/e2e-tests/cli.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe.skipIf(frameworkToTest || isQuarantineMode())(
promptHandlers: [
{
matcher: /What type of application do you want to create/,
input: [keys.enter],
input: [keys.down, keys.enter],
},
{
matcher: /Do you want to use TypeScript/,
Expand Down Expand Up @@ -82,7 +82,7 @@ describe.skipIf(frameworkToTest || isQuarantineMode())(
},
{
matcher: /What type of application do you want to create/,
input: [keys.down, keys.enter],
input: [keys.down, keys.down, keys.enter],
},
{
matcher: /Do you want to use TypeScript/,
Expand Down Expand Up @@ -112,7 +112,7 @@ describe.skipIf(frameworkToTest || isQuarantineMode())(
promptHandlers: [
{
matcher: /What type of application do you want to create/,
input: [keys.enter],
input: [keys.down, keys.enter],
},
{
matcher: /Do you want to use git for version control/,
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cloudflare/src/helpers/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export async function openInBrowser(url: string): Promise<void> {

export const C3_DEFAULTS = {
projectName: new Haikunator().haikunate({ tokenHex: true }),
type: "hello-world",
type: "webFramework",
framework: "angular",
autoUpdate: true,
deploy: true,
Expand Down

0 comments on commit 02359bc

Please sign in to comment.