Skip to content

Commit

Permalink
[C3] Bump create-solid from 0.2.26 to 0.3.6 in /packages/create-cloud…
Browse files Browse the repository at this point in the history
…flare/src/frameworks (#4012)

* [C3] Bump create-solid in /packages/create-cloudflare/src/frameworks

Bumps [create-solid](https://github.com/ryansolid/create-solid/tree/HEAD/packages/create-react-app) from 0.2.26 to 0.3.6.
- [Commits](https://github.com/ryansolid/create-solid/commits/HEAD/packages/create-react-app)

---
updated-dependencies:
- dependency-name: create-solid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* [C3] Update frameworks cli dependencies

* Use positional argument for project directory with create-solid

* fix lint issue

* Prevent prompt handlers from being consumed

* cd to project directory in configure step

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <[email protected]>
Co-authored-by: James <[email protected]>
  • Loading branch information
3 people authored Oct 3, 2023
1 parent cb4309f commit a21acf8
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 9 deletions.
5 changes: 5 additions & 0 deletions .changeset/c3-frameworks-update-4012.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-cloudflare": patch
---

C3: Bumped `create-solid` from `0.2.26` to `0.3.6`
2 changes: 2 additions & 0 deletions packages/create-cloudflare/e2e-tests/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ export const runC3 = async ({
const stdout: string[] = [];
const stderr: string[] = [];

promptHandlers = promptHandlers && [...promptHandlers];

await new Promise((resolve, rejects) => {
proc.stdout.on("data", (data) => {
const lines: string[] = data.toString().split("\n");
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cloudflare/src/frameworks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"create-qwik": "1.2.12",
"create-react-app": "5.0.1",
"create-remix": "2.0.0",
"create-solid": "0.2.26",
"create-solid": "0.3.6",
"create-svelte": "5.0.6",
"create-vue": "3.7.5",
"gatsby": "5.12.4",
Expand Down
13 changes: 5 additions & 8 deletions packages/create-cloudflare/src/frameworks/solid/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { mkdirSync } from "fs";
import { logRaw, updateStatus } from "helpers/cli";
import { blue, brandColor, dim } from "helpers/colors";
import { installPackages, runFrameworkGenerator } from "helpers/command";
Expand All @@ -11,18 +10,16 @@ import type { PagesGeneratorContext, FrameworkConfig } from "types";
const { npm, dlx } = detectPackageManager();

const generate = async (ctx: PagesGeneratorContext) => {
// Create the project directory and navigate to it
mkdirSync(ctx.project.path);
process.chdir(ctx.project.path);

// Run the create-solid command
const cli = getFrameworkCli(ctx);
await runFrameworkGenerator(ctx, `${dlx} ${cli}`);
await runFrameworkGenerator(ctx, `${dlx} ${cli} ${ctx.project.name}`);

logRaw("");
};

const configure = async () => {
const configure = async (ctx: PagesGeneratorContext) => {
process.chdir(ctx.project.path);

// Install the pages adapter
const pkg = "solid-start-cloudflare-pages";
await installPackages([pkg], {
Expand All @@ -37,7 +34,7 @@ const configure = async () => {
: `./vite.config.js`;
writeFile(viteConfigPath, viteConfig);
updateStatus(
`Adding the Cloudflare Pages adapter to ${blue("vite.config.js")}`
`Adding the Cloudflare Pages adapter to ${blue(viteConfigPath)}`
);
};

Expand Down

0 comments on commit a21acf8

Please sign in to comment.