-
Notifications
You must be signed in to change notification settings - Fork 759
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ignore OPTIONS requests in Oauth server (#5324)
- Loading branch information
Showing
2 changed files
with
6 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"wrangler": patch | ||
--- | ||
|
||
fix: Ignore OPTIONS requests in Wrangler's oauth server | ||
This comment has been minimized.
Sorry, something went wrong. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -960,6 +960,7 @@ export async function login( | |
|
||
assert(req.url, "This request doesn't have a URL"); // This should never happen | ||
const { pathname, query } = url.parse(req.url, true); | ||
if (req.method !== "GET") return res.end("OK"); | ||
This comment has been minimized.
Sorry, something went wrong.
petebacondarwin
Contributor
|
||
switch (pathname) { | ||
case "/oauth/callback": { | ||
let hasAuthCode = false; | ||
|
@penalosa - for future reference, I think it would be helpful to include information about symptoms of the problem that the user would have seen and the fact that this was needed to fix a change in Chrome, mentioning the version etc, so that it makes it easier for users to identify this release as solving that problem.